-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup errors #88
Cleanup errors #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a test case for ErrIncomplete
.
LGTM otherwise.
for testCase, isPull := range testCases { | ||
t.Run(testCase, func(t *testing.T) { | ||
// ctx, cancel := context.WithTimeout(ctx, 5*time.Second) | ||
// defer cancel() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: dead code.
} | ||
// send an error, but only if we haven't already errored for some reason | ||
if chst.Status() != datatransfer.Failing && chst.Status() != datatransfer.Failed { | ||
return m.channels.Error(chid, datatransfer.ErrIncomplete) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hannahhoward There's no test for ErrIncomplete
.
f7d85bd
to
a400317
Compare
… for a need to revalidate (#87) * feat(revalidator): add handled bool Previously, the revalidators were very ambiguous in identifying if they had actually handled a request for a revalidation check or not -- a "nil, nil" or "voucher result, nil" was interpreted as not being handled. This is unfortunate, cause particularly a "voucher result, nil" is an indication the request is handled by this check, and we should stop processing other revalidators that might override the value with "nil, nil". We now add a boolean to disambiguate whether the revalidator "recognized" this request --- if true, processing stops. * style(comments): fix types
cleanup errors -- move more error codes to proper types and insure single error dispatched
49fa579
to
cec9d80
Compare
Goals
Implementation